bdelacretaz commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024211896
##########
src/main/java/org/apache/sling/testing/Constants.java:
##########
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
*/
public static final String EXPECTED_STATUS = "expected_status";
+
+ /**
+ * User Agent
+ */
+ public static final String SLING_CLIENT_USERAGENT_TITLE =
"sling-testing-client";
Review Comment:
Backwards compatibility is somewhat "sacred" in Apache projects and I think
Sling strongly follows that principle.
If you have a good reason for a potentially breaking change, it should be
discussed on the [email protected] list, we cannot make such a decision here.
To keep things simple, I think users who are not aware of this change should
not see any difference in the behavior of the test clients, which speaks for
keeping "Java" as the existing default User-Agent value, even if that's not an
optimal choice. The documentation of this module can then point to that
suboptimal choice, which is here for historical reasons, and recommend that
users change the default for the reasons that you mention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
