anban02 opened a new pull request, #26:
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26

   Hello everyone
   
   about a year ago I opened the Issue 
[SLING-10110](https://issues.apache.org/jira/projects/SLING/issues/SLING-10110?filter=allopenissues).
 Now after a year i thought that I'd try to add the functionality for resolving 
Star-Wildcards myself.
   
   The idea here is that you can copy the ignoreUrlParams as they are from the 
Apache-Dispatcher-Config and add them to your slingDynamicInclude-config.
   
   There might be some Indent-Changes etc. that are probably not conform to the 
project. If there are any Code-Style Guidelines please tell me and I'll restyle 
the code as needed.
   
   Please also let me know if there is anything in my added code that does not 
perform well or could be done better. It was the best solution i could find at 
the moment but if someone has any ideas for improvements please let me know and 
I'll try to implement them.
   
   I also used Java8 Streaming-API but I'm not quite sure that the project runs 
above Java7. Maybe it only looked like that because some code-snippets looked a 
bit older to me. Please don't misunderstand this as something negative. It is 
only my personal perception.
   
   Thank you in advance for reviewing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to