anban02 commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1318377289
> @anban02 So when looking at the patch, it just translates a glob `*` into its equivalent regex counterpart `.*`; is this the gist of the patch? That is not all but a big part of it. In the current unpatched version the ignoreUrlParams matching is an exact value matching that did not allow the use of wildcards. But because Apache-Dispatcher Configurations allow wildcards I needed SDI to also correctly resolve ignoreUrlParams that were defined with wildcards. So to summarize it: i added a check for ignoreUrlParams to see if there is a wildcard configured in the style of a dispatcher config. If so then the `*` is translated to `.*` so i can do a regex match for that and see if the parameter that is currently checked should be ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
