rishabhdaim commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-event/pull/24#issuecomment-1451885145
> One concern that comes to mind: the way the PR is currently implemented results in a new JCR property `slingevent:progressLog:maxCount` to be stored in the repository for each job. That increases repository disk usage. While actually this value is more of a config value than something specific to individual jobs - ie each job would probably have the same value for this maxCount. > > IOW: do we need to store this value? Can't we only deal with the size of the log at job write time, in which case it would remain a private variable of the JobManagerImpl not used anywhere else? In case we don't save the value of `slingevent:progressLog:maxCount`, then we don't have any mechanism to copy this value while calling `Utility.readJob()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
