rishabhdaim commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-event/pull/24#issuecomment-1468317145
I think this is really an edge case and adding another entry with a `...truncated` message would only complicate things because: 1. We would be printing `...truncated` twice (after converting this to a string while logging) 2. and we would be breaking the contract of `progressLogMaxCount` I propose that we should ignore appending `...truncated` if it is already there. As you have already mentioned that this is really an edge case with chances for this to happen very slim, so I wouldn't take a very complicated way to handle this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
