jsedding commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46#issuecomment-1781033572
@anchela the test was intended to validate and document that it is possible to set properties on a group/user within the same `Session#save()` call. I.e. that there are no intermediate saves, which might break some use cases, like e.g. setting the `rep:externalId` property (which is NOT recommended, because it is an implementation detail and should only be managed by Oak's external authentication code). Instead of creating a complete security setup, which I feel is not trivial, I could implement a custom Oak `Validator` that has an analogous check. That way, the test also doesn't document "bad practice". Would that work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
