jsedding commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46#issuecomment-1786747126
hi @anchela, I tried to address your comments and suggestions in my latest commit. I'm not 100% sure about the `SecurityProvider` setup. I am trying to rely on its defaults, like before, but now I'm doing it explicitly, without violating any nullability annotations. Regarding the IDP implementation, I agree that would help, if the groups are transparently sync'ed on demand. I.e. if the external groups appear via Oak's APIs in the same way local groups do. Then it should be possible to just set ACLs for them via repoinit, and the groups would automatically, and transparently, be sync'ed. This test case more in order to document current behaviour of repoinit, than it is about a solution to the sync problem. I have dismissed this approach as bad practice, and will not recommend it to anyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
