kwin commented on code in PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1404094590
##########
src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java:
##########
@@ -16,27 +16,37 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.sling.jcr.resource.internal;
+package org.apache.sling.jcr.resource.api;
import org.apache.sling.api.resource.observation.ResourceChange;
/**
- * Extension of {@code ResourceChange} to support user id (if available)
+ * Extension of {@code ResourceChange} to support user id and user data (if
available)
*/
-public class JcrResourceChange extends ResourceChange {
+public final class JcrResourceChange extends ResourceChange {
Review Comment:
Well it could, but it doesn't in this case, therefore I don't see a reason
to open this here right now (due to restricting evolution of this class
unnecessarily). Once again, if we come up with a good use case we can still
change that, but let us always start with the most restricted API.
@henrykuijpers If you have a convincing use case for extending please tell us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
