henrykuijpers commented on code in PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1404146108
##########
src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java:
##########
@@ -16,27 +16,37 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.sling.jcr.resource.internal;
+package org.apache.sling.jcr.resource.api;
import org.apache.sling.api.resource.observation.ResourceChange;
/**
- * Extension of {@code ResourceChange} to support user id (if available)
+ * Extension of {@code ResourceChange} to support user id and user data (if
available)
*/
-public class JcrResourceChange extends ResourceChange {
+public final class JcrResourceChange extends ResourceChange {
Review Comment:
No, I'm fine with leaving it restricted. The class, at this moment, doesn't
contain a lot of logic.
There have been quite some cases where it was very useful that "internal"
implementations were freely accessible (for example JcrLabeledResource in
Adobe's codebase, it contains quite some code to read the right properties etc)
- creating a wrapper would still be possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
