jsedding commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1608323556
##########
src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java:
##########
@@ -92,6 +92,9 @@ public void execute(final InstallationContext ctx) {
}
Configuration config =
ConfigUtil.getConfiguration(this.getConfigurationAdmin(), this.factoryPid,
this.configPid);
+ if (config == null) {
+ config =
ConfigUtil.getLegacyFactoryConfig(this.getConfigurationAdmin(),
this.factoryPid, null, this.configPid);
+ }
Review Comment:
I don't think this is a complete fix (together with
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9).
The `original.pid` property is not leveraged. Installation would need to be
skipped if the `original.pid` property is present AND a configuration with that
PID exists in config admin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
