rishabhdaim commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1608464507
##########
src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java:
##########
@@ -92,6 +92,9 @@ public void execute(final InstallationContext ctx) {
}
Configuration config =
ConfigUtil.getConfiguration(this.getConfigurationAdmin(), this.factoryPid,
this.configPid);
+ if (config == null) {
+ config =
ConfigUtil.getLegacyFactoryConfig(this.getConfigurationAdmin(),
this.factoryPid, null, this.configPid);
+ }
Review Comment:
I agree that I haven't checked whether the `original.pid` property is
present or not cause I didn't need it (may be we can remove it altogether).
Regarding the checking of config, the `ConfigUtil.getLegacyFactoryConfig`
does check it
[here](https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/master/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigUtil.java#L251-L256)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
