running "mvn clean verify" on the extracted source ZIP under windows works just 
fine.
but I was able to reproduce the problem in linux, so it definitely seems to be 
a line ending issue in the source ZIP.
did you do this validation on my past releases as well?

i suppose my git core.autocrlf config got mixed up with the latest git client 
update.

so i think i should cancel the release? and maybe include SLING-12483 in the 
next run?

stefan

> -----Original Message-----
> From: Robert Munteanu <[email protected]>
> Sent: Wednesday, November 13, 2024 11:06 AM
> To: [email protected]
> Subject: Re: [VOTE] Release Apache Sling Models Implementation 1.7.4
> 
> Hi,
> 
> The source archive does not build for me, it fails on the spotless
> check:
> 
> [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-
> plugin:2.43.0:check (default) on project org.apache.sling.models.impl: The
> following files had format violations:
> (snip)
> [ERROR] Violations also present in 189 other files.
> [ERROR] Run 'mvn spotless:apply' to fix these violations.
> 
> Not sure where those are coming from. The tag builds just fine for me.
> Running a diff -ur shows many differences between files. Might be a
> line ending issue?
> 
> Thanks,
> Robert

Reply via email to