[ 
https://issues.apache.org/jira/browse/SLING-12440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913864#comment-17913864
 ] 

Peter Tos commented on SLING-12440:
-----------------------------------

[~joerghoh] I think the documentation may need some clarification rather than 
this being an implementation issue. As [~estebusta] showed, the documentation 
states that we should extend the marker interface. This is correct if we are 
creating a Sitemap Extension within the Sling Sitemap codebase. 

If we are creating a custom Sitemap Extension within a delivery codebase (e.g. 
within AEM), then we should implement `
org.apache.sling.sitemap.spi.builder.SitemapExtensionProvider` instead.

> Extension incorrectly annotated with @ProviderType
> --------------------------------------------------
>
>                 Key: SLING-12440
>                 URL: https://issues.apache.org/jira/browse/SLING-12440
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Peter Tos
>            Priority: Major
>              Labels: sitemaps
>         Attachments: image-2025-01-16-16-19-35-924.png
>
>
> org.apache.sling.sitemap.builder.Extension is annotated with @ProviderType, 
> but the implementation requires the consumer to extend this interface. This 
> should be changed to @ConsumerType.
>  
> https://github.com/apache/sling-org-apache-sling-sitemap/blob/master/src/main/java/org/apache/sling/sitemap/builder/Extension.java#L29



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to