[ 
https://issues.apache.org/jira/browse/SLING-12440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921610#comment-17921610
 ] 

Dirk Rudolph commented on SLING-12440:
--------------------------------------

Isn't it enough to extend the AbstractExtension class? You can register the 
SitemapExtensionProvider with the full qualified class name or define an 
interface, and using either to call `Url#addExtension()`.

Extending the marker interface directly should not be necessary. But I agree 
the README is misleading. 

> Extension incorrectly annotated with @ProviderType
> --------------------------------------------------
>
>                 Key: SLING-12440
>                 URL: https://issues.apache.org/jira/browse/SLING-12440
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Peter Tos
>            Priority: Major
>              Labels: sitemaps
>         Attachments: image-2025-01-16-16-19-35-924.png
>
>
> org.apache.sling.sitemap.builder.Extension is annotated with @ProviderType, 
> but the implementation requires the consumer to extend this interface. This 
> should be changed to @ConsumerType.
>  
> https://github.com/apache/sling-org-apache-sling-sitemap/blob/master/src/main/java/org/apache/sling/sitemap/builder/Extension.java#L29



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to