stefan-egli commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/12#issuecomment-2828207189
Wondering whether `TopologyReadinessHandler` indeed needs to be a `TopologyEventListener` after all. Why is `shouldDelayTopologyChange` dependent on `topologyChangeInProgress`? Also: why is it dependent on `delayDuration`? Isn't it much simpler and all `TopologyReadinessHandler` needs is the dependency on `SystemReady`, and based on that, together with the stateMachine, `shouldDelayTopologyChange` basically just returns `!stateMachine.isReady()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
