stefan-egli commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/12#issuecomment-2828244078
There's an issue with the shutdown. The startup case should work fine via `shouldDelayTopologyChange` (which is based on `ready`). The shutdown however should work differently: the way the logic is implemented now is essentially a no-op: it calls `setOldView` but typically with the same topology as before, as typically the topology (as of now) doesn't change just because readiness changes. What it should do in shutdown instead is that there is no topology anymore - i.e. it should result in a `TOPOLOGY_CHANGING` event for all local listeners. That's not what the current code achieves though. I'd recommend to model an integration/cluster test that allows to simulate such a scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
