Dear Apache Sling Team,

Thank you for your hints and guidance. We have completely and successfully
tested the migration to SLF4J 2.x (`6.0.0` of
`org.apache.sling.commons.log`), and it proved to be very straightforward:
https://github.com/ciechanowiec/sling_rocket/commit/6bef3e5a1c92b465e59464df8a295935b69f472f.
Everything works as expected.

Since we have several confirmations that everything works fine, could you,
please, proceed with the release of `6.0.0` version?

On 29.04.2025 06:29, Eric Norman wrote:
> Hi Herman,
>
> When using the documented "Separate Logback, SLF4j Installation" style of
> configuration, the order that the bundles are started is important.  This
> is to ensure that the custom sling logback configuration service is
> activated before the slf4j logging factory tries to use it.
>
> I've prepared a draft pull request at
> https://github.com/apache/sling-org-apache-sling-starter/pull/463 that
> contains the changes to the starter that I have been using.
>
> I haven't tried the "Embedded Installation" style of configuration, so that
> may be a bit different.
>
> Regards,
> Eric
>
>
> On Mon, Apr 28, 2025 at 9:39 AM Herman Ciechanowiec <her...@ciechanowiec.eu>
> wrote:
>
>> Dear Robert,
>>
>> Thanks for the suggestion. We've tested the `6.0.0-SNAPSHOT` version of
>> `org.apache.sling.commons.log` in our application.
>>
>> The good news is that the bundle installs correctly and doesn't seem to
>> cause major failures or unresolved package imports based on our initial
>> smoke tests.
>>
>> However, we encountered an issue where logging doesn't function as
>> expected, even though we followed the official installation instructions (
>>
>> https://sling.apache.org/documentation/development/logging.html#separate-logback-slf4j-installation
>> ).
>> The Sling launcher console log shows SLF4J warnings indicating that no
>> providers were found:
>>
>> [INFO] Apache Sling Application Launcher
>> [INFO] ---------------------------------
>> [INFO] Initializing...
>> [INFO] Artifact Repositories: [file:///Users/herman/.m2/repository/,
>> https://repo.maven.apache.org/maven2,
>> https://repository.apache.org/content/groups/snapshots]
>> [INFO] Assembling final feature model...
>> [INFO]
>> [INFO] Assembling launcher...
>> [INFO] Using 270 local artifacts, 0 cached artifacts, and 0 downloaded
>> artifacts
>> [INFO]
>> [INFO] Starting launcher...
>> [INFO] Launcher Home: /Users/herman/apache_sling/logs/launcher
>> [INFO] Cache Directory: /Users/herman/apache_sling/logs/launcher/cache
>> [INFO]
>> [INFO] Using framework factory class
>> org.apache.felix.framework.FrameworkFactory
>> SLF4J(W): No SLF4J providers were found.
>> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
>> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further
>> details.
>> Apr 28, 2025 5:53:08 PM org.apache.aries.spifly.BaseActivator log
>> INFO: Registered provider
>> ch.qos.logback.classic.servlet.LogbackServletContainerInitializer of
>> service jakarta.servlet.ServletContainerInitializer in bundle
>> ch.qos.logback.classic
>> Apr 28, 2025 5:53:08 PM org.apache.aries.spifly.BaseActivator log
>> INFO: Registered provider ch.qos.logback.classic.spi.LogbackServiceProvider
>> of service org.slf4j.spi.SLF4JServiceProvider in bundle
>> ch.qos.logback.classic
>> Apr 28, 2025 5:53:08 PM org.apache.aries.spifly.BaseActivator log
>> INFO: Registered provider
>> org.apache.sling.commons.log.logback.spi.DefaultConfigurator of service
>> ch.qos.logback.classic.spi.Configurator in bundle
>> org.apache.sling.commons.log
>> SLF4J(W): No SLF4J providers were found.
>> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
>> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further
>> details.
>> Apr 28, 2025 5:53:08 PM org.apache.aries.spifly.BaseActivator log
>> INFO: Registered provider org.eclipse.jetty.http.Http1FieldPreEncoder of
>> service org.eclipse.jetty.http.HttpFieldPreEncoder in bundle
>> org.apache.felix.http.jetty
>> Apr 28, 2025 5:53:08 PM org.apache.aries.spifly.BaseActivator log
>> INFO: Registered provider
>> org.eclipse.jetty.http2.hpack.HpackFieldPreEncoder of service
>> org.eclipse.jetty.http.HttpFieldPreEncoder in bundle
>> org.apache.felix.http.jetty
>> Apr 28, 2025 5:53:09 PM
>> org.apache.tika.config.InitializableProblemHandler$3
>> handleInitializableProblem
>>
>> Unfortunately, due to current project priorities, we don't have the
>> bandwidth to investigate this logging configuration issue further at this
>> moment.
>>
>> Our plan is likely to wait until the new `commons-log` version is
>> integrated into the official `sling-starter` project (
>> https://github.com/apache/sling-org-apache-sling-starter). We can then
>> reference or replicate that working configuration.
>>
>> Hope this feedback is helpful for the release process.
>>
>> On 2025/04/28 11:07:27 Robert Munteanu wrote:
>>> Hi Herman,
>>>
>>> On Sat, 2025-04-26 at 12:03 +0200, Herman Ciechanowiec wrote:
>>>> Dear Apache Sling Team,
>>>>
>>>> Could you please release the current version of Apache Sling Commons
>>>> Log
>>>> (6.0.0-SNAPSHOT,
>>>> https://github.com/apache/sling-org-apache-sling-commons-log) to
>>>> Maven
>>>> Central? This build adds support for SLF4J 2.x (SLING-12750), which
>>>> our
>>>> project needs to upgrade several security-related dependencies. We
>>>> would be
>>>> very grateful if you could make the release available as soon as
>>>> possible.
>>>>
>>>
>>> Since you are interested in the release, could you please run some
>>> smoke tests with this SNAPSHOT version with your project and let us
>>> know if everything works as expected?
>>>
>>> It's a big change and additional testing will help build the confidence
>>> of the release manager.
>>>
>>> Thanks,
>>> Robert
>>>
>>
>> Kind regards,
>>
>> Herman Ciechanowiec
>> her...@ciechanowiec.eu
>>
>


Kind regards,

Herman Ciechanowiec
her...@ciechanowiec.eu

Reply via email to