bkkothari2255 commented on code in PR #69:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/69#discussion_r2683664980
##########
pom.xml:
##########
@@ -160,6 +160,17 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
Review Comment:
> Rather the engine should not pollute the testing classpath. Just add the
APIs and add the necessary engines as plugin dependencies as outlined in
https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#How_to_run_multiple_APIs_or_Engines
Understood. That makes sense—it will keep the compile-time classpath
cleaner. Thanks for pointing that out
I will push this update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
