rombert commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/33#issuecomment-3805732468
> > Ok. Well conceptually, switching to using the SlingBindings should work to get the wrappers applied. But I wouldn't want to approve the changes without some way to verify it works in practice. Ideally some automated integration test to make sure it isn't broken again in the future. Especially since I have never used the precompiled scripts myself so I am not very familiar with the flow. > > Yes, that makes sense. I'll try and see if I can add a precompiled script to the starter tests. @enapps-enorman - I made the following changes: - added bundled script support to the starter test services - https://github.com/apache/sling-org-apache-sling-starter-test-services/pull/22 - added tests for JSP and HTL bundled scripts to the starter integration tests - https://github.com/apache/sling-org-apache-sling-starter-integration-tests/pull/43 Those tests are not enough to trigger the failures. They only happen when the HTL scripting engine has the scriptResolutionCache enabled. I configured in a draft PR to demonstrate the problem - https://github.com/apache/sling-org-apache-sling-starter/pull/579 . I don't think we should merge it as-is because there is no out-of-the-box issue; the test should be on a lower level, which I think this PR provides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
