rombert commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/33#issuecomment-3805744468
> We used to have extensive tests for bundled/precompiled scripts in https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it. Unfortunately, that module hasn't been maintained in a while (my fault too...), and it doesn't build with Java 17 or newer. > > Given that we now ship support for bundled/precompiled scripts in our code modules, maybe we should move those tests into the starter? Thanks for the review @raducotescu . I added a couple of basic tests ( see my reply to Eric ). For the extensive tests I think we should follow the approach that @stefanseifert took and include the ITs in the implementation module - see [Move integration tests to impl project - sling models impl](https://lists.apache.org/thread/dcogmzq40cknj5sxxbmj2yjlbsjvkcfp) because they are closer to the code they yest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
