enapps-enorman commented on code in PR #75:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/75#discussion_r3253373515
##########
src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java:
##########
@@ -323,7 +274,12 @@ private ParameterMap getRequestParameterMapInternal() {
addContainerParameters = false;
useFallback = false;
} else {
- this.parseMultiPartPost(parameters);
+ try {
+ this.parseMultiPartPost(parameters);
+ } catch (final ServletException | IOException e) {
+ this.log.error(
+ "getRequestParameterMapInternal: Error
parsing multipart streamed request", e);
Review Comment:
I will change the log message to remove "steamed". From what I can tell the
old commons-fileupload based implementation would also eat parsing errors and
log them so this isn't new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
