enapps-enorman commented on code in PR #75:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/75#discussion_r3253381666
##########
src/main/java/org/apache/sling/engine/impl/parameters/ParameterMap.java:
##########
@@ -125,19 +128,19 @@ public Map<String, String[]> getStringParameterMap() {
public Object getPart(final String name) {
final RequestParameter p = this.getValue(name);
- if (p instanceof MultipartRequestParameter) {
- return new SlingPart((MultipartRequestParameter) p);
+ if (p instanceof MultipartRequestParameter mrp) {
+ return mrp.getPart();
Review Comment:
~~Do you know if jetty does anything regarding encoding fixup of the
submitted file name? If the container handles it already then we wouldn't need
it.~~
UPDATE: It looks like Jetty does not automatically "fix up" or sanitize
uploaded file names. It treats the submitted file name exactly as it is sent.
So I can restore the SlingPart wrapping to keep compatibility for that purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
