[
https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466734#comment-13466734
]
Justin Edelson commented on SLING-2593:
---------------------------------------
A few comments on the changes committed thus far:
* Please fix formatting - Sling uses 4 spaces for indentation.
* Is it appropriate for the tests (e.g. ResolveNonExistingWith1000AliasTest) to
be annotated with @RunWith? AFAIK, they are not runnable tests.
* Is the class AbstractPerformanceTest used anymore? It seems like no. If not,
why does it exist?
* Why is System.getenv() used in ReportLogger rather than System.getProperty() ?
* Why is there an XML ReportType enum value if it isn't supported?
> Improvement for the Sling performance tools
> --------------------------------------------
>
> Key: SLING-2593
> URL: https://issues.apache.org/jira/browse/SLING-2593
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Vazzolla-Popa Cristian-George
> Assignee: Antonio Sanso
> Priority: Minor
> Attachments: performance_patch_2.patch,
> sling_performance_framework_refactoring.patch
>
>
> Added a few improvements to the Sling performance testing tools:
> 1. Added the possibility to run each test method in a class as a performance
> test; until now a test was represented by a class (for each new test you had
> to add a new java class)
> 2. Added a PerformanceTest annotation that is used to discover the test
> methods in a java class
> 3. Added the possibility to provide with the PerformanceTest annotation a few
> configuration parameters for the test like the warmup time, run time , warm
> up invocations or run invocations; by default the warmuptime and runtime are
> used but a user can choose not to count on the time but to prefer setting the
> number of test invocations that he wants to be made during the test run
> 4. Created a new maven project that contains only the sling performance tests
> and left the framework(tool) related part in the base project as we would
> like to use the framework for performance testing in other projects also
> 5. Added the possibility to have parameters sent to test suite object, added
> a before suite and after suite method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
