[
https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466750#comment-13466750
]
Vazzolla-Popa Cristian-George commented on SLING-2593:
------------------------------------------------------
Hi Justin,
1. Regarding the AbstractPerformanceTest and also AbstractTest classes, was my
mistake that they did not appear in the initial patch file I've sent.
So the two classes should be removed as they are not used anymore in the sling
performance tests. I'm not aware of other tests that were using
these classes before, but if they are they will need to be modified not to use
them anymore.
2. The System.getenv() is used instead of System.getProperty() because if
someone wants to set the test suite name from outside the
test itself it would not be able to do that.
The use case I want to be able to achieve is :
- set suite name (maybe equal to product version)
- download a specified product version by using maven command line and run the
performance tests
- copy the result reports for that build
- delete the environment variable
and do this for several product builds/versions from a bat/sh file (or from a
Jenkins job) like below:
set testsuitename=build1
call mvn -PdownloadSpecificBuild -PrunTests clean verify test
xcopy "target/performance-reports" "performance-reports/%testsuitename%" /D /E
/C /R /I /K /Y
set "testsuitename="
set testsuitename=build2
call mvn -PdownloadSpecificCQ -PrunTests clean verify test
xcopy "target/performance-reports" "performance-reports/%testsuitename%" /D /E
/C /R /I /K /Y
3. Regarding the RunWith and XML ReportType I've talked with Antonio and he
will do the modification:
- remove @RunWith for the tests as they are not runnable
- remove XML ReportType until will be supported
I can create a new patch if you think is necessary.
Regards,
Cristian
> Improvement for the Sling performance tools
> --------------------------------------------
>
> Key: SLING-2593
> URL: https://issues.apache.org/jira/browse/SLING-2593
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Vazzolla-Popa Cristian-George
> Assignee: Antonio Sanso
> Priority: Minor
> Attachments: performance_patch_2.patch,
> sling_performance_framework_refactoring.patch
>
>
> Added a few improvements to the Sling performance testing tools:
> 1. Added the possibility to run each test method in a class as a performance
> test; until now a test was represented by a class (for each new test you had
> to add a new java class)
> 2. Added a PerformanceTest annotation that is used to discover the test
> methods in a java class
> 3. Added the possibility to provide with the PerformanceTest annotation a few
> configuration parameters for the test like the warmup time, run time , warm
> up invocations or run invocations; by default the warmuptime and runtime are
> used but a user can choose not to count on the time but to prefer setting the
> number of test invocations that he wants to be made during the test run
> 4. Created a new maven project that contains only the sling performance tests
> and left the framework(tool) related part in the base project as we would
> like to use the framework for performance testing in other projects also
> 5. Added the possibility to have parameters sent to test suite object, added
> a before suite and after suite method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
