Hi, On Tue, Sep 30, 2014 at 9:21 AM, Carsten Ziegeler <[email protected]> wrote: > I've thought a little bit more about the model and I came up with a > slightly different syntax... > https://svn.apache.org/repos/asf/sling/trunk/launchpad/slingstart/src/main/model/example.txt ...
Looks good to me, a few comments below. I would require a header like [sling.feature] name=Example feature description=Optional description to make sure people at least think about what they put in there ;-) And require it before any comments so that such files can be identified by the unix "file" command. Should have both local (to the feature) and global variables? We can simply require global variables to have a name starting with g. like g.oak.version - a variable that does not start with g. is then local to the feature file. And complain if a global variable is set more than once. Are [settings] meant to be OSGi framework settings? I need those for Crankstart. What is "sling.options", does it already have a defined meaning? As mentioned in my previous message I suggest [artifacts] runModes:jackrabbit,author startLevel:5 commons-io/commons-io/1.4/jar ... Instead of embedding run modes and start level in section headers. I'm using colons after the property names as we used to have artifact:commons... which is now the default, but we might have installer:some.artifact or other similar property qualifiers. Apart from that I think your example covers our immediate needs, and the syntax is sufficiently extensible - it seems to have everything I currently use in Crankstart (http://svn.apache.org/repos/asf/sling/trunk/contrib/crankstart/launcher/src/test/resources/launcher-test.crank.txt) -Bertrand
