Hi,
2014-10-01 14:22 GMT+02:00 Bertrand Delacretaz <[email protected]>: > I would require a header like > > [sling.feature] > name=Example feature > description=Optional description > > to make sure people at least think about what they put in there ;-) > > Good point, agreed (I don't agree on the syntax though :) ) > > Should have both local (to the feature) and global variables? We can > simply require global variables to have a name starting with g. like > g.oak.version - a variable that does not start with g. is then local > to the feature file. And complain if a global variable is set more > than once. > Variables are currently local to a feature - do we need global variables? When e.g. overriding a variable from a system property it could use "feature.VARNAME" as the key. > > Are [settings] meant to be OSGi framework settings? I need those for > Crankstart. > > Yes. > What is "sling.options", does it already have a defined meaning? > This is a defined framework property for the sling run mode handling. It tells Sling's launchpad that one of the two run modes will be active, but exactly one. If not specified by the environment, the first one is activated automatically. > > As mentioned in my previous message I suggest > > [artifacts] > runModes:jackrabbit,author > startLevel:5 > commons-io/commons-io/1.4/jar > ... > > Instead of embedding run modes and start level in section headers. I'm > using colons after the property names as we used to have > artifact:commons... which is now the default, but we might have > installer:some.artifact or other similar property qualifiers. > > I think having the attributes of a section (run mode, start level) in the same line is more readable and understandable. We also have the metadata notation, so your use case of adding the "installer" info could be handled today by this. Carsten > Apart from that I think your example covers our immediate needs, and > the syntax is sufficiently extensible - it seems to have everything I > currently use in Crankstart > ( > http://svn.apache.org/repos/asf/sling/trunk/contrib/crankstart/launcher/src/test/resources/launcher-test.crank.txt > ) > > -Bertrand > -- Carsten Ziegeler Adobe Research Switzerland [email protected]
