Hi Sandro, On Wed, 2014-11-12 at 13:39 +0100, Sandro Boehme wrote: > Hello, > > does somebody have the time to commit my first patch [1] for my Sling > Resource Editor contribution [2]?
I planned to look at it at some point - no promise that I will find the time to do that :-) - but since you asked on the list ... I personally prefer patches to be smaller and self-contained and be linked to individual Jira issues. Your issue contains a list of improvements and I think the patch is quite large - 613k . I would suggest to split these into multiple, smaller patches. If you have large, noisy, changes like renames or moves or splitting of trees, make them as separate patches so the rest are easier to review. Cheers, Robert > > [1] - https://issues.apache.org/jira/browse/SLING-4141 > [2] - https://issues.apache.org/jira/browse/SLING-4001 > > Best Sandro > > BTW: I god nice issue numbers, right? ;-) Maybe you'll get SLING-4444, fingers crossed :-)
