Hi Robert,
I got it wrong. Or course a simple split would work. Even though initial
commits may overlap which leads to the new add-node dialog changes to be
hidden in the patch for the restructuring of the folders.
But for reviewing it's probably easier.
I splitted the patch up into smaller ones and created sub-tasks for them.
Thanks,
Sandro
Am 12.11.14 23:04, schrieb Sandro Boehme:
Hi Robert,
thanks for thinking about committing the patch.
The patch is not self contained because AFAIK the SVN patch format does
not have information about deleted files. Only about deleted file
content. I would appreciate it if somebody has a workaround for that.
I don't see a way to easily split the patch into smaller ones.
The only way I see would be to send the first patch e.g. containing the
first 6 commits up to the first directory structure change. Then someone
would need to commit it. After that I can update my svn working
directory. Only after 'svn up' I can create a diff for the next patch
and so on.
If someone is willing to commit the patches I would create them one
after another. But that would take quite some time.
If it's just about being easier to review then one could also have a
look at the commit history and its diffs over at the GitHub project [1]
starting at the commit 'fix for #5' (c822fc8) from the 7th of october. I
think this would be quite convenient to review.
(Of course the third option would be to commit it myself... ;-) )
[1] - https://github.com/sandroboehme/resourceeditor/commits/master
Best,
Sandro
Am 12.11.14 14:05, schrieb Robert Munteanu:
Hi Sandro,
On Wed, 2014-11-12 at 13:39 +0100, Sandro Boehme wrote:
Hello,
does somebody have the time to commit my first patch [1] for my Sling
Resource Editor contribution [2]?
I planned to look at it at some point - no promise that I will find the
time to do that :-) - but since you asked on the list ...
I personally prefer patches to be smaller and self-contained and be
linked to individual Jira issues. Your issue contains a list of
improvements and I think the patch is quite large - 613k .
I would suggest to split these into multiple, smaller patches. If you
have large, noisy, changes like renames or moves or splitting of trees,
make them as separate patches so the rest are easier to review.
Cheers,
Robert
[1] - https://issues.apache.org/jira/browse/SLING-4141
[2] - https://issues.apache.org/jira/browse/SLING-4001
Best Sandro
BTW: I god nice issue numbers, right? ;-)
Maybe you'll get SLING-4444, fingers crossed :-)
