[ 
https://issues.apache.org/jira/browse/SLING-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214833#comment-14214833
 ] 

Konrad Windszus commented on SLING-4138:
----------------------------------------

I opened a pull request with my proposed changes to the Validator interface 
which now supports
#  acting on arbitrary data types (not only String)
#  cross-checks among multiple properties
#  array validation

So in my regard the points b) and d) from SLING-4027 should be solved by that
[~cziegeler] What do you think?

If no one opposes, I will commit the changes from the pull request on Wednesday.


> Allow validator to support arbitrary types
> ------------------------------------------
>
>                 Key: SLING-4138
>                 URL: https://issues.apache.org/jira/browse/SLING-4138
>             Project: Sling
>          Issue Type: Improvement
>          Components: Validation
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: Validation 1.0.0
>
>
> Currently the {{Validator.validate}} method only act on String values. 
> Since type conversion is already built into the ValueMap, it would be good to 
> leverage that and to allow Validator to act on arbitrary types there!
> Also the type conversion from ValueMap should be leveraged to do the type 
> check in {{ValidationServiceImpl.validatePropertyValue}} rather than 
> implementing a new thing in {{Type.isValid()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to