[ 
https://issues.apache.org/jira/browse/SLING-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214839#comment-14214839
 ] 

Konrad Windszus commented on SLING-4138:
----------------------------------------

I also needed to rely on {{TypeUtils}} from commons-lang3 
(https://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/reflect/TypeUtils.html)
 which allows to extract the type parameter from the Validation implementation. 
I therefore embedded commons-lang3 in the validator-impl bundle.

> Allow validator to support arbitrary types
> ------------------------------------------
>
>                 Key: SLING-4138
>                 URL: https://issues.apache.org/jira/browse/SLING-4138
>             Project: Sling
>          Issue Type: Improvement
>          Components: Validation
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: Validation 1.0.0
>
>
> Currently the {{Validator.validate}} method only act on String values. 
> Since type conversion is already built into the ValueMap, it would be good to 
> leverage that and to allow Validator to act on arbitrary types there!
> Also the type conversion from ValueMap should be leveraged to do the type 
> check in {{ValidationServiceImpl.validatePropertyValue}} rather than 
> implementing a new thing in {{Type.isValid()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to