[ 
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246455#comment-14246455
 ] 

Carsten Ziegeler commented on SLING-4216:
-----------------------------------------

The patch lgtm in general, I have two comments:
- we could skip querying the bloom filter if the cache contains all values
- the point Vikas is raising that the vanity paths might change while the 
instance is down needs imho be addressed. I guess simply rebuilding the filter 
should do the trick; the old/cached filter can be used until the new one is 
built

> Limit the number of vanityPath MapEntry 
> ----------------------------------------
>
>                 Key: SLING-4216
>                 URL: https://issues.apache.org/jira/browse/SLING-4216
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>         Attachments: SLING-4216-patch.txt
>
>
> At the moment there isn't any limit to the number of MapEntry that are cached 
> in memory.
> If the number of vanityPaths/alias is extremely high this can cause OOM.
> It would be good to have a way to limit the amount of memory used by the 
> MapEntry cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to