[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246464#comment-14246464
]
Antonio Sanso commented on SLING-4216:
--------------------------------------
[~cziegeler] thanks for reviewing.
bq. we could skip querying the bloom filter if the cache contains all values
isn't this logic already "taking care" of it ? Unless I am missing something :S
{code}
if (BloomFilterUtils.probablyContains(vanityBloomFilter, vanityPathName)) {
mapEntries = this.resolveMapsMap.get(vanityPath);
if (mapEntries == null) {
Map<String, List<MapEntry>> mapEntry =
getVanityPaths(vanityPathName);
mapEntry.putAll(resolveMapsMap);
mapEntries = mapEntry.get(vanityPath);
}
}
{code}
about the second point I agree.... So let me come with a proper patch :)
> Limit the number of vanityPath MapEntry
> ----------------------------------------
>
> Key: SLING-4216
> URL: https://issues.apache.org/jira/browse/SLING-4216
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-4216-patch.txt
>
>
> At the moment there isn't any limit to the number of MapEntry that are cached
> in memory.
> If the number of vanityPaths/alias is extremely high this can cause OOM.
> It would be good to have a way to limit the amount of memory used by the
> MapEntry cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
