[ 
https://issues.apache.org/jira/browse/SLING-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377747#comment-14377747
 ] 

Tomek Rękawek commented on SLING-4223:
--------------------------------------

I tried to merge, but some integration test fail on the whiteboard branch:

{noformat}
  HttpPingTest.testWebServerRoot:36 Status must be 302 for 
http://localhost:8888/ expected:<302> but was:<200>
  InitialContentTest.testInitialContentInSubNodeRoot:54 Content contains 
"testProperty":"value" ({"jcr:created":"Tue Mar 24 2015 12:21:42 
GMT+0100","jcr:primaryType":"sling:Folder","jcr:createdBy":"admin"})
  InitialContentTest.testRootRedirectProperty:33 Content contains 
"sling:resourceType":"sling:redirect" 
({"jcr:mixinTypes":["mix:lockable","rep:AccessControllable"],"jcr:primaryType":"rep:root"})
  PostServletImportTest.testImportJSONFromFileWithoutOptionalName:412 null
  
PostServletImportTest.testImportNodeWithAlreadyUsedExactName:775->importNodeWithExactName:733
 Node (http://localhost:8888/sling-import-tests/alreadyUsedExactNodeName.json) 
must have exact name 'alreadyUsedExactNodeName'
  PostServletImportTest.testImportReplaceProperties:225->assertExpectedJSON:122 
Value of key: propOne expected:<propOneValueChanged> but was:<propOneValue>
  
PostServletImportTest.testImportNodeWithExactName:743->importNodeWithExactName:733
 Node (http://localhost:8888/sling-import-tests/exactNodeName.json) must have 
exact name 'exactNodeName'
  PostServletImportTest.testImportAutoCheckoutNodes:354 expected:<def[2]> but 
was:<def[]>
  PostServletImportTest.testImportJSONFromRequestParamWithoutOptionalName:477 
null
  PostServletImportTest.testImportReplace:153 
expected:<.../sling-import-tests/[nodeName]> but 
was:<.../sling-import-tests/[.json]>
{noformat}

In the meantime I try to fix the SLING-4538 in the current trunk version.

> Make Content Loader extensible to support new import formats
> ------------------------------------------------------------
>
>                 Key: SLING-4223
>                 URL: https://issues.apache.org/jira/browse/SLING-4223
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR ContentLoader 2.1.10
>            Reporter: Oliver Lietz
>            Assignee: Tomek Rękawek
>             Fix For: JCR ContentLoader 2.2.0
>
>         Attachments: SLING-4223.patch
>
>
> The current Content Loader supports a basic set of import formats which are 
> identified by extension: {{.xml}}, {{.jcr.xml}}, {{.json}}, {{.jar}} and 
> {{.zip}}.
> There is a [user 
> request|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3cd0a6198c.20fbeb%[email protected]%3e]
>  to support custom formats like Adobe Folio and [some ideas how to 
> implement|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%[email protected]%3e]:
> * we create a new org.apache.sling.contentloader.reader package to be 
> exported at version 1.0
> * move the ContentCreator (@ProviderType) and ContentReader (@ConsumerType) 
> to that new package
> * convert the BaseImportLoader into a standalone ContentReader service holder 
> used by the DefaultContentImporter and ContentLoaderService components.
> * For the ContentReader service interface we define service registration 
> properties for the service to expose the file name extension (and maybe 
> content type) the reader supports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to