[ 
https://issues.apache.org/jira/browse/SLING-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379774#comment-14379774
 ] 

Bruce Edge commented on SLING-4223:
-----------------------------------

Either approach works for me. I'm all for KISS in theory, so I assume there's 
some use case addressed by the additional inheritance in the BaseContentReader 
as opposed to the original whiteboard approach.

> Make Content Loader extensible to support new import formats
> ------------------------------------------------------------
>
>                 Key: SLING-4223
>                 URL: https://issues.apache.org/jira/browse/SLING-4223
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR ContentLoader 2.1.10
>            Reporter: Oliver Lietz
>            Assignee: Tomek Rękawek
>             Fix For: JCR ContentLoader 2.2.0
>
>         Attachments: SLING-4223.patch
>
>
> The current Content Loader supports a basic set of import formats which are 
> identified by extension: {{.xml}}, {{.jcr.xml}}, {{.json}}, {{.jar}} and 
> {{.zip}}.
> There is a [user 
> request|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3cd0a6198c.20fbeb%25bruce.e...@nextissuemedia.com%3e]
>  to support custom formats like Adobe Folio and [some ideas how to 
> implement|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3ca2ab572f-fa83-4ae2-806e-49cce87b9...@adobe.com%3e]:
> * we create a new org.apache.sling.contentloader.reader package to be 
> exported at version 1.0
> * move the ContentCreator (@ProviderType) and ContentReader (@ConsumerType) 
> to that new package
> * convert the BaseImportLoader into a standalone ContentReader service holder 
> used by the DefaultContentImporter and ContentLoaderService components.
> * For the ContentReader service interface we define service registration 
> properties for the service to expose the file name extension (and maybe 
> content type) the reader supports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to