[ 
https://issues.apache.org/jira/browse/SLING-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640147#comment-14640147
 ] 

Marius Petria commented on SLING-4895:
--------------------------------------

I think we can safely move the updateServiceMappings out of the synchronized 
block and use a concurrent map for the activeMappingRegistrations. Basically, 
it all comes down to updating activeMappingRegistrations from the 
activeMappings and the conflict can occur only if the same key is involved. It 
does not look probable to have a conflict on the same mapping, but even if it 
happens I think we can solve it without additional synchronization. I will try 
to write a patch for it.

> Service registry should not be called from within synchronized block
> --------------------------------------------------------------------
>
>                 Key: SLING-4895
>                 URL: https://issues.apache.org/jira/browse/SLING-4895
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Service User Mapper 1.2.0
>            Reporter: Carsten Ziegeler
>             Fix For: Service User Mapper 1.2.2
>
>
> RIght now, if e.g. an amendment is added/removed/updated, all 
> registration/unregistration is done in a "large" synchronized block. This 
> should be avoided



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to