[
https://issues.apache.org/jira/browse/SLING-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645607#comment-14645607
]
Carsten Ziegeler commented on SLING-4895:
-----------------------------------------
I'll have a look. I think there is also a bug in the updateServiceMappings
method, it does:
if (!activeMappingRegistrations.containsKey(mapping)) {
...
and later on
final ServiceRegistration oldRegistration =
activeMappingRegistrations.put(mapping, registration);
but this will always return null as the if already checked that there is no
value in the map.
> Service registry should not be called from within synchronized block
> --------------------------------------------------------------------
>
> Key: SLING-4895
> URL: https://issues.apache.org/jira/browse/SLING-4895
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Service User Mapper 1.2.0
> Reporter: Carsten Ziegeler
> Fix For: Service User Mapper 1.2.2
>
> Attachments: SLING-4895.diff
>
>
> RIght now, if e.g. an amendment is added/removed/updated, all
> registration/unregistration is done in a "large" synchronized block. This
> should be avoided
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
