[
https://issues.apache.org/jira/browse/SLING-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745306#comment-14745306
]
Carsten Ziegeler commented on SLING-5025:
-----------------------------------------
Thanks, the changes look basically good - except for the duplicate !isLive
check :)
However, after looking at context.isLive() again, I think we shouldn't check
it for is closed.
> Make ResourceResolver methods throw ISE in case the according factory is
> unregistered
> -------------------------------------------------------------------------------------
>
> Key: SLING-5025
> URL: https://issues.apache.org/jira/browse/SLING-5025
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.2.6
> Reporter: Konrad Windszus
> Attachments: SLING-5025-api.v01.diff,
> SLING-5025-resourceresolver.v01.diff, SLING-5025.v02.diff
>
>
> In SLING-4360 the {{ResourceResolver.isLive()}} method was extended to check
> if the {{ResourceResolverFactory}} has been unregistered in the mean time.
> That check should be done in addition for every method on the resource
> resolver and should throw an ISE in case the factory is no longer registered.
> See also the discussion at
> http://www.mail-archive.com/[email protected]/msg49364.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
