[
https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163727#comment-15163727
]
Robert Munteanu commented on SLING-3100:
----------------------------------------
Digging more into the code, I see some pom properties that are recognised by
the configurator and I'd like to see if they are really needed:
* {{M2E_ACTIVE}} - if found, configuration is skipped. Do we really need this?
* {{M2E_NATURES}} - extra natures to add. Again, what's the scenario for this?
* {{M2E_JCR_ROOT_PATH}} - can't we infer it from the pom file? I've seen this
always defined in the {{build/resources/resource}} directory with the
{{jcr_root}} name
* {{M2E_USE_WTP_PROJECT_SETUP}} - I see that some WTP validations don't work
with it ; which ones? We disable the XML validator anyway due to spurious
validation errors in the vault files
* {{M2E_JAVA_FACET_VERSION}} - can't we infer it from the maven-compiler-plugin
configuration, just like it is done by the m2e java configurator?
* {{M2E_WEB_FACET_VERSION}} - we might need this one in the end, but maybe we
can always infer it somewhere :-)
The reason I'm asking is that I prefer things explicitly configured for Maven
and not to add special instructions for Eclipse. Fewer configuration options ->
simpler maintenance ( unless we really need them ).
> Provide a m2e project configurator for packaging "content-package"
> ------------------------------------------------------------------
>
> Key: SLING-3100
> URL: https://issues.apache.org/jira/browse/SLING-3100
> Project: Sling
> Issue Type: New Feature
> Components: IDE
> Affects Versions: Sling Eclipse IDE 1.0.0
> Reporter: Konrad Windszus
> Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.1.0
>
> Attachments: 0001-WIP-do-not-push.patch,
> SLING-3100-m2e-integration.patch
>
>
> To set up the appropriate project configuration just from the POM an
> according m2e project configurator is needed
> (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29)
> The m2e-war-plugin comes with a project configurator which works also for
> content-packages pretty well but it is currently hard to reuse for any other
> packaging than "war" (due to the delegate pattern being used internally,
> compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if
> the project is having the dynamic web project facet the following features in
> Eclipse are supported:
> - JSP include directives (considered for validation and supports ctrl+click
> to open linked file)
> - Tag Library Support (
> http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F
> )
> - probably other features as well.
> Apart from that a feature like overlays should be supported (
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often
> content-package projects are referencing JSPs from other projects, and the
> IDE needs to know those, to complete the validation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
