[ 
https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169067#comment-15169067
 ] 

Robert Munteanu commented on SLING-3100:
----------------------------------------

Thanks for the timely reply ( unlike mine :-) ) . I dug some more into the 
code, and have the following proposal

* {{M2E_ACTIVE}} - keep ( for now ) to aid with situations where the 
configurator can create problems. Probably remove in the next feature release ( 
1.2.0 )
* {{M2E_NATURES}} - remove, as you suggested as well
* {{M2E_JCR_ROOT_PATH}} - remove, same as above
* {{M2E_USE_WTP_PROJECT_SETUP}} - remove, but default to using it. This (at 
least) makes more file types appare in the New... menu and is probably closed 
to what we want in terms of use experience
* {{M2E_JAVA_FACET_VERSION}} - keep, as I don't find a simple way of 
controlling the Java version from the pom file _unless_ it was configured 
before converting the project
* {{M2E_WEB_FACET_VERSION}} - keep ( for now ) , although I think inferring 
from the servlet-api dependency should be enough and consider for removal in 
next future release ( 1.2.0 ) 

How does that sound?

> Provide a m2e project configurator for packaging "content-package"
> ------------------------------------------------------------------
>
>                 Key: SLING-3100
>                 URL: https://issues.apache.org/jira/browse/SLING-3100
>             Project: Sling
>          Issue Type: New Feature
>          Components: IDE
>    Affects Versions: Sling Eclipse IDE 1.0.0
>            Reporter: Konrad Windszus
>            Assignee: Robert Munteanu
>             Fix For: Sling Eclipse IDE 1.1.0
>
>         Attachments: 0001-WIP-do-not-push.patch, 
> SLING-3100-m2e-integration.patch
>
>
> To set up the appropriate project configuration just from the POM an 
> according m2e project configurator is needed 
> (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29)
> The m2e-war-plugin comes with a project configurator which works also for 
> content-packages pretty well but it is currently hard to reuse for any other 
> packaging than "war" (due to the delegate pattern being used internally, 
> compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if 
> the project is having the dynamic web project facet the following features in 
> Eclipse are supported:
> - JSP include directives (considered for validation and supports ctrl+click 
> to open linked file)
> - Tag Library Support ( 
> http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F
>  )
> - probably other features as well.
> Apart from that a feature like overlays should be supported ( 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often 
> content-package projects are referencing JSPs from other projects, and the 
> IDE needs to know those, to complete the validation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to