> Hi Carsten, > > >> There is an AbstractHtmlClientImpl but just one implementation. Can't >> this be merged into a single class? > AbstractHtmlClientImpl takes away all the http stuff and leaves an abstract > method that would allow it to easily write a new HtmlClient that returns a > different type of Document. Might not have one now, but I'm using that in > an external project and would allow anyone to easily achieve that. Is it a > big problem? I personally would like to leave it.
It's not a big problem, it just looks a little bit strange, especially as the impl is in a different package then the service/class which creates the implementation. But again, nothing which really needs to be changed. > >> Although org.apache.sling.hapi.client.forms is exported, it's only use is >> in an implementation. So why not make this private? > You're right again :) What I'm having trouble with the meanings, due to my > lack of expertise in OSGi and mixing osgi concepts and bnd maven plugin > isntructions. Do you mean not exporting it (i.e. forbidden), or making it > private via the maven bundle plugin? I added "<Private-Package> > org.apache.sling.hapi.client.forms</Private-Package>" to the bundle plugin > and the maniefst file doesn't seem to change :/ Anything I'm doing wrong? > How should a private package show? Any way I can make it work? Not exporting or making it private should be the same. I looked at your change and tbh I have no idea why it doesn't work. I think the best would be to simply rename the package to *.impl - this way it is obvious that its not a public/exported package. And it will be automatically handled as such. > > I will drop this release, sort out these issues and continue from there. Thanks, really appreciated. And again, sorry for looking so late at it Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland [email protected]
