Anyone, please?

On Wed, Aug 10, 2016 at 4:56 PM Andrei Dulvac <[email protected]> wrote:

> Hi,
> We solved 3 issues for this initial 
> release:https://issues.apache.org/jira/browse/SLING/fixforversion/12337959
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachesling-1499/
>
>
> You can use this UNIX script to download the release and verify the 
> signatures:http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> Usage:
>
> sh check_staged_release.sh 1499 /tmp/sling-staging
>
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> This majority vote is open for at least 72 hours.
>
>
>
> On Wed, Aug 10, 2016 at 3:01 PM Oliver Lietz <[email protected]>
> wrote:
>
>> On Wednesday 10 August 2016 14:04:00 Carsten Ziegeler wrote:
>> [...]
>> > Not exporting or making it private should be the same. I looked at your
>> > change and tbh I have no idea why it doesn't work. I think the best
>> > would be to simply rename the package to *.impl - this way it is obvious
>> > that its not a public/exported package. And it will be automatically
>> > handled as such.
>>
>> Or internal instead of impl. IMHO internal illustrates the intent more
>> obvious
>> than impl as we also export packages with classes which implement
>> functions.
>> We also have impl packages in Sling with interfaces in it.
>>
>> Regards,
>> O.
>>
>> > > I will drop this release, sort out these issues and continue from
>> there.
>> >
>> > Thanks, really appreciated. And again, sorry for looking so late at it
>> >
>> > Regards
>> > Carsten
>>
>>

Reply via email to