[
https://issues.apache.org/jira/browse/SLING-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692545#comment-15692545
]
Bertrand Delacretaz commented on SLING-6285:
--------------------------------------------
What's your use case for
{{AbstractSlingRepositoryManager.isAllowLoginAdministrativeForBundleOverridden}}
?
IIUC it optionally makes AbstractSlingRepositoryManager independent from the
presence of a LoginAdminWhitelist - but IMO we want to force the use of that
component. Also, using reflection in
{{isAllowLoginAdministrativeForBundleOverridden}} is unusual - if we want to
make the whitelist optional we might as well have a method or annotation that
expresses this in a cleaner way.
> Implement LoginAdminWhitelist in JCR Base
> -----------------------------------------
>
> Key: SLING-6285
> URL: https://issues.apache.org/jira/browse/SLING-6285
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Base 2.4.2
> Reporter: Julian Sedding
> Assignee: Julian Sedding
> Fix For: JCR Oak Server 1.1.4, JCR Base 3.0.0
>
> Attachments: SLING-6285-jsedding.patch
>
>
> JCR Base should provide a default implementation
> {{AbstractSlingRepositoryManager#allowLoginAdministrativeForBundle(Bundle)}}
> with a configurable {{LoginAdminWhitelist}}. Implementation that want a
> different logic can then still choose to overwrite the method.
> cc [~cziegeler], [~bdelacretaz]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)