[ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936988#comment-15936988
 ] 

Stefan Seifert commented on SLING-6679:
---------------------------------------

thanks for your efforts this far!

i had a brief look at some of the patches - i've noticed you replaced
{code:java}
catch (JSONException e)
{code}
with
{code}
catch (Exception e)
{code}

this is not equivalent - the javax.json API throws unchecked exceptions derived 
from RuntimeException - they will not be caught. we might just catch 
{{javax.json.JsonException}}.

and we see from the patches that the migration on serveral modules is quite 
complex - and thus error-prone.

> Replace usage of org.apache.sling.commons.json.*
> ------------------------------------------------
>
>                 Key: SLING-6679
>                 URL: https://issues.apache.org/jira/browse/SLING-6679
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to