[jira] [Commented] (SLING-6702) Make MetricsService accessible as easily as a Logger

[Oliver Lietz (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SLING-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938981#comment-15938981
 ] 

Oliver Lietz commented on SLING-6702:
-------------------------------------

[~bdelacretaz], you can remove {{launchpad()}} completely. Commons Metrics 
doesn't depend on Sling:

{noformat}
    public static Option slingCommonsMetrics() {
        return composite(
            scr(),
            
mavenBundle().groupId("org.apache.sling").artifactId("org.apache.sling.commons.metrics").version(versionResolver),
            
mavenBundle().groupId("io.dropwizard.metrics").artifactId("metrics-core").version(versionResolver)
        );
    }
{noformat}

> Make MetricsService accessible as easily as a Logger
> ----------------------------------------------------
>
>                 Key: SLING-6702
>                 URL: https://issues.apache.org/jira/browse/SLING-6702
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Commons Metrics 1.2.0
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: Commons Metrics 1.2.2
>
>
> Metrics are useful in all classes, not only OSGi components, so getting the 
> {{MetricsService}} should be as useful as getting a {{Logger}} for example.
> I'll add a public {{MetricsServiceFactory}} class to our metrics module, 
> usable like
> {code}
>   MetricsService ms = 
> MetricsServiceFactory.getMetricsService(this.getClass());
> {code}
> There's already a private {{MetricsServiceFactory}} class in that module, 
> I'll rename that to {{InternalMetricsServiceFactory}} to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)