[ 
https://issues.apache.org/jira/browse/SLING-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953564#comment-15953564
 ] 

Felix Meschberger commented on SLING-6702:
------------------------------------------

bq. prevent it from getting unregistering

[~chetanm] This is just not possible: Consider the bundle is stopped and 
restarted.

bq. Note that currently MetricsServiceImpl is not using any OSGi config and has 
no required dependency on any other service.

As you say currently. When you add it and forget to abide by the expectation of 
MetricsServiceFactory, you get a failure.

Your call to ignore this warning, but it is an existing fragility.

> Make MetricsService accessible as easily as a Logger
> ----------------------------------------------------
>
>                 Key: SLING-6702
>                 URL: https://issues.apache.org/jira/browse/SLING-6702
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Commons Metrics 1.2.0
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: Commons Metrics 1.2.2
>
>
> Metrics are useful in all classes, not only OSGi components, so getting the 
> {{MetricsService}} should be as useful as getting a {{Logger}} for example.
> I'll add a public {{MetricsServiceFactory}} class to our metrics module, 
> usable like
> {code}
>   MetricsService ms = 
> MetricsServiceFactory.getMetricsService(this.getClass());
> {code}
> There's already a private {{MetricsServiceFactory}} class in that module, 
> I'll rename that to {{InternalMetricsServiceFactory}} to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to