[
https://issues.apache.org/jira/browse/SLING-6782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975316#comment-15975316
]
Jörg Hoh commented on SLING-6782:
---------------------------------
Hi Carsten,
good point. But from my point of view in the context of Sling Jobs,
autoCommit=false would never make sense for the creation of the parent path. So
we should ignore this flag for that in any case and always do the commit. And
only act on autoCommit when it's about saving the resoource.
> Sling Job implementation should avoid unnecessary writes to the repository
> --------------------------------------------------------------------------
>
> Key: SLING-6782
> URL: https://issues.apache.org/jira/browse/SLING-6782
> Project: Sling
> Issue Type: Improvement
> Components: Event
> Affects Versions: Event 4.2.2
> Reporter: Jörg Hoh
> Attachments: SLING-6782-jobs-commit-to-often.patch
>
>
> I found in a number of occurences in the Sling Event code this pattern:
> {code}
> ResourceHelper.getOrCreateResource(resolver, newPath,
> props);
> resolver.delete(jobResource);
> resolver.commit();
> {code}
> and the getOrCreateResource is internally doing a commit on the resolver
> (autoCommit = true). So in the end there are 2 commits while only a single
> commit would be sufficient.
> Removing these "double" commits could avoid a few write operations on the
> repository.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
