[
https://issues.apache.org/jira/browse/SLING-6782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975467#comment-15975467
]
Jörg Hoh commented on SLING-6782:
---------------------------------
For this case I adapted the ResourceHelper.getOrCreateResourceInternal a update
and made the commit for the creation of the parentPath mandatory (updated
patch).
But then we cannot remove this local copy of this method and replace it by the
ResourceUtil version, because there the commit of creation of the parentPath
should still depend on autoCommit.
> Sling Job implementation should avoid unnecessary writes to the repository
> --------------------------------------------------------------------------
>
> Key: SLING-6782
> URL: https://issues.apache.org/jira/browse/SLING-6782
> Project: Sling
> Issue Type: Improvement
> Components: Event
> Affects Versions: Event 4.2.2
> Reporter: Jörg Hoh
> Attachments: SLING-6782-jobs-commit-to-often-2.patch,
> SLING-6782-jobs-commit-to-often.patch
>
>
> I found in a number of occurences in the Sling Event code this pattern:
> {code}
> ResourceHelper.getOrCreateResource(resolver, newPath,
> props);
> resolver.delete(jobResource);
> resolver.commit();
> {code}
> and the getOrCreateResource is internally doing a commit on the resolver
> (autoCommit = true). So in the end there are 2 commits while only a single
> commit would be sufficient.
> Removing these "double" commits could avoid a few write operations on the
> repository.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
