[
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292890#comment-16292890
]
Julian Sedding commented on SLING-7313:
---------------------------------------
Thanks [~kwin] for looking onto this. I haven't had time to test it yet. My
solution would have looked very similar to yours, I decided to omit the
try/catch and allow it to throw a {{RuntimeException}} (which should not happen
anyways, I assume?).
> ResourceResolverImpl#refresh should also refresh the internal
> resourceTyperesourceResolver
> ------------------------------------------------------------------------------------------
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.5.32
> Reporter: Julian Sedding
> Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see
> attachment) and traced them back to a long-lived service {{ResourceResolver}}
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}}
> call is not propagated to the internal {{resourceTypeResourceResolver}} used
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think
> we should also refresh the internal {{resourceTypeResourceResolver}} used by
> {{ResourceResolverImpl}} when RR is refreshed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
