[
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301130#comment-16301130
]
ASF GitHub Bot commented on SLING-7313:
---------------------------------------
jsedding commented on issue #1: SLING-7313 refresh the resource type resolver
as well
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#issuecomment-353552868
@kwin I don't think there's an issue with synchronization here. AFAIU we're
in the implementation details of a single ResourceResolver, which is documented
as NOT thread-safe. Therefore it would be a programming error if it was used
concurrently.
I like the change as it is now.
cc @cziegeler you know these parts well, I would appreciate if you could
double-check. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ResourceResolverImpl#refresh should also refresh the internal
> resourceTyperesourceResolver
> ------------------------------------------------------------------------------------------
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.5.32
> Reporter: Julian Sedding
> Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see
> attachment) and traced them back to a long-lived service {{ResourceResolver}}
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}}
> call is not propagated to the internal {{resourceTypeResourceResolver}} used
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think
> we should also refresh the internal {{resourceTypeResourceResolver}} used by
> {{ResourceResolverImpl}} when RR is refreshed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
