Makes sense and I was kind of suspecting this would be the case. To enable the ServiceUser Console to work in a separate bundle though, I do need to make the Mapping class public and expose the getActiveMappings method on the ServiceUserMapper interface as shown below:
https://github.com/apache/sling-org-apache-sling-serviceusermapper/compare/master...klcodanr:master Does that pose any issues? If not I'll go ahead and start on getting Service User Mapper 1.4.0 and adding the Service User Console bundle. I'm assuming this is okay from a naming perspective: - Git Repo Name: sling-org-apache-sling-serviceuser-console - artifactId: org.apache.sling.serviceuser.console - name: Apache Sling Service User Console Thanks, Dan On Tue, Jan 9, 2018 at 2:42 AM, Robert Munteanu <[email protected]> wrote: > Hi Dan, > > On Mon, 2018-01-08 at 17:19 -0800, Daniel Klco wrote: > > Hey Devs, > > > > I've noticed a lot of friction with the adoption of Service Users and > > I > > wonder if it might help to make a tool to make it easier to create / > > update > > service users. > > > > I put together an OSGi Console which makes it pretty darn easy to > > create > > service users, lists the available service users and allows you to > > see a > > Filter and example usage of each mapped service user. > > > > Right now, I've forked the Apache Sling Service User Mapper bundle > > and you > > can see a working example here: > > > > https://github.com/klcodanr/sling-org-apache-sling-serviceusermapper > > Have not tried it, but it sounds useful indeed. > > > > > So a couple questions: > > > > > > - Does this sound like something we want to include? > > - Should it go in the Launchpad or be an addon? > > - Does including this in the ServiceUserMapper bundle make sense? > > At the moment the serviceusermapper has some carefully chosen > dependencies, presumably to make it available as early as possible. > > Import-Package: org.apache.felix.inventory; resolution:=optional; > version="[1.0, 2)", org.apache.sling.serviceusermapping; version="[1.3, > 1.4)", org.osgi.framework; version="[1.4, 2)", > org.osgi.framework.hooks.service; version="[1.1, 2)", org.slf4j; > version="[1.7, 2)" > > I think that allowing it to start early is a major advantage, so making > the dependency a separate bundle would be useful. > > Thanks, > > Robert >
